[webkit-reviews] review granted: [Bug 53554] make draft comments focusable : [Attachment 80856] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 53554: make draft comments focusable
https://bugs.webkit.org/show_bug.cgi?id=53554

Attachment 80856: Patch
https://bugs.webkit.org/attachment.cgi?id=80856&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80856&action=review

This is fine, but consider the comments below.	BTW, I love j/k.  :)

> Websites/bugs.webkit.org/code-review.js:1280
> -	 if (node.hasClass(className)) {
> +	 if (focus_type == FOCUS_TYPE.COMMENT &&
(node.hasClass('frozenComment') || node.hasClass('previousComment')) ||
> +	     focus_type == FOCUS_TYPE.DIFF_BLOCK && node.hasClass('DiffBlock'))
{

I'd just pass in a function that you call at this branch.  That stops this code
from having to know about all the different types.