[webkit-reviews] review granted: [Bug 53496] Replace PCRE with Yarr in WebCore : [Attachment 80762] proposed patch v1.1

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Peter Varga
<pvarga at webkit.org>'s request for review:
Bug 53496: Replace PCRE with Yarr in WebCore
https://bugs.webkit.org/show_bug.cgi?id=53496

Attachment 80762: proposed patch v1.1
https://bugs.webkit.org/attachment.cgi?id=80762&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
Shame, looks like a couple of test bots have stalled?  r+, since after a day of
waiting the ones that did run are green.
This patch looks good as is, and getting rid of PCRE will be fantastic.  I
think it would probably be even better to try to unify jsc/runtime/RegExp with
WebCore's RegularExpression class (with the product of this merge likely living
in wtf/text?) - whether this is ultimately possible or not, this patch is a
really great step in the right direction.