[webkit-reviews] review requested: [Bug 53558] Make WebProcess pass explicit homedir parameter to the sandbox : [Attachment 80859] sandbox-homedir-path

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has asked  for review:
Bug 53558: Make WebProcess pass explicit homedir parameter to the sandbox
https://bugs.webkit.org/show_bug.cgi?id=53558

Attachment 80859: sandbox-homedir-path
https://bugs.webkit.org/attachment.cgi?id=80859&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80859&action=review

> Source/WebKit2/WebProcess/mac/WebProcessMac.mm:130
> +    if (!realpath(getenv("HOME"), homeRealPath)) {

Why are we relying on the HOME environment variable rather than using
NSHomeDirectory or lower level calls to retrieve the user’s home directory?