[webkit-reviews] review denied: [Bug 52974] [Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl : [Attachment 80794] patch3
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 1 16:30:27 PST 2011
Andreas Kling <kling at webkit.org> has denied qi <qi.2.zhang at nokia.com>'s request
for review:
Bug 52974: [Qt] enum QWebPage::WebAction doesn't have value
QWebPage::CopyImageUrl
https://bugs.webkit.org/show_bug.cgi?id=52974
Attachment 80794: patch3
https://bugs.webkit.org/attachment.cgi?id=80794&action=review
------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80794&action=review
> Source/WebKit/qt/Api/qwebpage.cpp:2740
> + case CopyImageUrlToClipboard:
> + text = tr("Copy Image Address");
> + break;
This should be done through the platform strategy.
We'll need a contextMenuItemTagCopyImageURLToClipboard(), though it can be #if
PLATFORM(QT) specific.
More information about the webkit-reviews
mailing list