[webkit-reviews] review granted: [Bug 53202] Async event handlers should not fire within a modal dialog : [Attachment 80846] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 53202: Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202

Attachment 80846: Patch
https://bugs.webkit.org/attachment.cgi?id=80846&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80846&action=review

Looks good, although I wonder if we shouldn't assimilate the m_suspend timer
instead.  Also while you're in SuspendableTimer.h can you make the c'tor
explicit?

> Source/WebCore/page/SuspendableTimer.h:50
> +    bool m_active;

nit: this should be declared after the doubles so it packs better.