[webkit-reviews] review granted: [Bug 53157] new-run-webkit-tests: add first stub of test_runner2 : [Attachment 80162] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 53157: new-run-webkit-tests: add first stub of test_runner2
https://bugs.webkit.org/show_bug.cgi?id=53157

Attachment 80162: Patch
https://bugs.webkit.org/attachment.cgi?id=80162&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80162&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:34
> +The TestRunner class runs a series of tests (TestType interface) against a
set
> +of test files.  If a test file fails a TestType, it returns a list
TestFailure
> +objects to the TestRunner.  The TestRunner then aggregates the TestFailures
to
> +create a final report.

This comment doesn't seem to describe this file (TestRunner2).	Maybe mention
what this is going to be used for and what it does now.

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:468
> +

Can you add a test with --child-processes and --worker-model?