[webkit-reviews] review denied: [Bug 52128] ISO-8859-8 Hebrew text displayed reversed with dir="rtl" : [Attachment 80800] patch w/ layout test

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Xiaomei Ji <xji at chromium.org>'s request for review:
Bug 52128: ISO-8859-8 Hebrew text displayed reversed with dir="rtl"
https://bugs.webkit.org/show_bug.cgi?id=52128

Attachment 80800: patch w/ layout test
https://bugs.webkit.org/attachment.cgi?id=80800&action=review

------- Additional Comments from mitz at webkit.org
This is not a very elegant way to achieve this behavior (whose benefit is
questionable anyway), and it’s unfortunate that BidiResolver is even used (and
goes through all the work of resolving bidi levels) for lines that override
bidi reordering. It’s especially ugly that this comes in the form of an extra
parameter which you can’t even tell only affects the visualOrder == true case.
At the very least, I think you should instead of adding a parameter, change the
existing parameter to an enum type such as DirectionOverride { NoOverride,
LeftToRightOverride, RightToLeftOverride }.