[webkit-reviews] review granted: [Bug 53534] Send messages when entering/exiting accelerated compositing : [Attachment 80828] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 53534: Send messages when entering/exiting accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=53534

Attachment 80828: Patch
https://bugs.webkit.org/attachment.cgi?id=80828&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80828&action=review

> Source/WebKit2/Shared/LayerTreeContext.h:50
> +#if PLATFORM(MAC)
> +    uint32_t contextID;
> +#endif

A public data member on a class? Eww!

> Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.h:54
> +    RetainPtr<WKCARemoteLayerClientRef> m_remoteLayerRef;

Why "Ref"? How about m_remoteLayerClient?

> Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.mm:36
> +#import <WebKitSystemInterface.h>

Missing a WebKitSystemInterface/

> Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.mm:56
> +    // FIXME: Create a real layer.
> +    CALayer *layer = [CALayer layer];

Huh? How is this an unreal layer?