[webkit-reviews] review denied: [Bug 53462] Using Control-C to cancel webkit-patch or other python tools causes unpleasant traceback console spew : [Attachment 80793] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 1 11:35:22 PST 2011


Mihai Parparita <mihaip at chromium.org> has denied Adam Barth
<abarth at webkit.org>'s request for review:
Bug 53462: Using Control-C to cancel webkit-patch or other python tools causes
unpleasant traceback console spew
https://bugs.webkit.org/show_bug.cgi?id=53462

Attachment 80793: Patch
https://bugs.webkit.org/attachment.cgi?id=80793&action=review

------- Additional Comments from Mihai Parparita <mihaip at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80793&action=review

> Tools/Scripts/webkit-patch:72
> +	   pass

Exiting with a non-0 exit code seems better (see
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/run_we
bkit_tests.py#L440)


More information about the webkit-reviews mailing list