[webkit-reviews] review granted: [Bug 53296]=?UTF-8?Q?=20Implicit=20form=20submission=20shouldn=E2=80=99t=20work=20when=20the=20default=20button=20is=20disabled=20?=: [Attachment 80702] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 1 10:32:57 PST 2011


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Mathias Bynens
<mathias at qiwi.be>'s request for review:
Bug 53296: Implicit form submission shouldn’t work when the default button is
disabled
https://bugs.webkit.org/show_bug.cgi?id=53296

Attachment 80702: Patch
https://bugs.webkit.org/attachment.cgi?id=80702&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
I think you forgot to change HTMLInputElement to plumb isSubmitButton, too?

Also, before this patch can land, you need to persuade Alexey that it should :)


More information about the webkit-reviews mailing list