[webkit-reviews] review denied: [Bug 53474] Don't cause a relayout when resetting the page scale factor is restored : [Attachment 80718] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 1 10:02:23 PST 2011


Darin Adler <darin at apple.com> has denied John Abd-El-Malek <jam at chromium.org>'s
request for review:
Bug 53474: Don't cause a relayout when resetting the page scale factor is
restored
https://bugs.webkit.org/show_bug.cgi?id=53474

Attachment 80718: Patch
https://bugs.webkit.org/attachment.cgi?id=80718&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Why is it OK to not call setNeedsLayout in restoreScrollPositionAndViewState?
What’s the guarantee that layout is OK? You’ll at least need a comment
explaining why that’s true.


More information about the webkit-reviews mailing list