[webkit-reviews] review granted: [Bug 53037] layoutTestController.counterValueForElementById does not return the correct value : [Attachment 80767] Proposed Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Carol Szabo <carol.szabo at nokia.com>'s
request for review:
Bug 53037: layoutTestController.counterValueForElementById does not return the
correct value
https://bugs.webkit.org/show_bug.cgi?id=53037

Attachment 80767: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=80767&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80767&action=review

Feel free to have another committer change commit-queue from - to + if you
decide you don’t want to make my suggested minor tweaks.

> Source/WebCore/rendering/RenderTreeAsText.cpp:773
> +    // The counter renderers should be children of
> +    // :before or :after pseudo-elements.

No reason to break this comment into two lines.

> Source/WebCore/rendering/RenderTreeAsText.cpp:780
> +	   RenderObject* pseudoElement =
renderer->beforePseudoElementRenderer();
> +	   if (pseudoElement)
> +	       writeCounterValuesFromChildren(stream, pseudoElement,
isFirstCounter);
> +	   pseudoElement = renderer->afterPseudoElementRenderer();
> +	   if (pseudoElement)
> +	       writeCounterValuesFromChildren(stream, pseudoElement,
isFirstCounter);

I suggest putting the local variable definitions into the if statements.