[webkit-reviews] review requested: [Bug 53235] Web Inspector: new api for managing JavaScript breakpoints : [Attachment 80772] Patch.

[bugzilla-daemon at webkit.org]

Pavel Podivilov <podivilov at chromium.org> has asked  for review:
Bug 53235: Web Inspector: new api for managing JavaScript breakpoints
https://bugs.webkit.org/show_bug.cgi?id=53235

Attachment 80772: Patch.
https://bugs.webkit.org/attachment.cgi?id=80772&action=review

------- Additional Comments from Pavel Podivilov <podivilov at chromium.org>
Update after offline discussion.

[domain=Debugger] void setJavaScriptBreakpoint(in String url, in int
lineNumber, in int columnNumber, in String condition, in boolean enabled, out
String breakpointId, out Array locations);
[domain=Debugger] void setJavaScriptBreakpointBySourceId(in String sourceId, in
int lineNumber, in int columnNumber, in String condition, in boolean enabled,
out String breakpointId, out int actualLineNumber, out int actualColumnNumber);

[domain=Debugger] void removeJavaScriptBreakpoint(in String breakpointId);
[notify, domain=Debugger] void breakpointResolved(out String breakpointId, out
String sourceId, out int lineNumber, out int columnNumber);

There are two methods for setting a breakpoint:
1. setJavaScriptBreakpoint - sets provisional breakpoint by url, backend would
set it in all scripts with matching url and notify front-end using
breakpointResolved notification
2. setJavaScriptBreakpointBySourceId - sets a breakpoint into a single script
by sourceId, breakpoint won't be restored after navigation