[webkit-reviews] review requested: [Bug 53436] [Gtk] atk_text_get_caret_offset fails for list items : [Attachment 80766] Patch proposal + unit tests

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 53436: [Gtk] atk_text_get_caret_offset fails for list items
https://bugs.webkit.org/show_bug.cgi?id=53436

Attachment 80766: Patch proposal + unit tests
https://bugs.webkit.org/attachment.cgi?id=80766&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #3)
> (From update of attachment 80659 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=80659&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +	     (webkit_accessible_text_get_caret_offset): Ajust the offset with
> 
> Should be "Adjust" here.

Fixed
 
> > Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:1231
> > +	     offset += g_utf8_strlen(markerText.utf8().data(), -1);
> 
> Unless I'm mistaken, if you want the offset in bytes, you should use
strlen(markerText.utf8().data()) if you want the offset in characters you can
just use markerText.length().

You're right. Thanks for noticing.

Fixed either there and in webkit_accessible_text_set_caret_offset (and updated
the ChangeLog)