[webkit-reviews] review denied: [Bug 47700] Make mime type lookup in File::create(path) thread-safe : [Attachment 80710] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 1 08:57:40 PST 2011
David Levin <levin at chromium.org> has denied Dai Mikurube
<dmikurube at google.com>'s request for review:
Bug 47700: Make mime type lookup in File::create(path) thread-safe
https://bugs.webkit.org/show_bug.cgi?id=47700
Attachment 80710: Patch
https://bugs.webkit.org/attachment.cgi?id=80710&action=review
------- Additional Comments from David Levin <levin at chromium.org>
This looks good. One last thing to fix up wherever you added
ASSERT(isMainThread()); please make sure that the file has the following
includes:
#include <wtf/Assertions.h>
#include <wtf/MainThread.h>
I spot checked MIMETypeRegistryWinCE.cpp and MimeTypeRegistryWx.cpp and noticed
they didn't have these so those builds may get broken by this change.
More information about the webkit-reviews
mailing list