[webkit-reviews] review granted: [Bug 53173] Web Inspector: [Chromium] Landing detailed heap snapshots, part 1 : [Attachment 80752] comments addressed
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 1 08:15:16 PST 2011
Pavel Feldman <pfeldman at chromium.org> has granted Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 53173: Web Inspector: [Chromium] Landing detailed heap snapshots, part 1
https://bugs.webkit.org/show_bug.cgi?id=53173
Attachment 80752: comments addressed
https://bugs.webkit.org/attachment.cgi?id=80752&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80752&action=review
> Source/WebCore/inspector/front-end/HeapSnapshot.js:683
> + if (fieldName1 === "!edgeName")
Please surround with {}
> Source/WebCore/inspector/front-end/HeapSnapshot.js:746
> + function(indexA, indexB) {
please declare named local function above (as sortByNodeField).
More information about the webkit-reviews
mailing list