[webkit-reviews] review denied: [Bug 52974] [Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl : [Attachment 80756] patch2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 1 07:58:57 PST 2011


Benjamin Poulain <benjamin.poulain at nokia.com> has denied qi
<qi.2.zhang at nokia.com>'s request for review:
Bug 52974: [Qt] enum QWebPage::WebAction doesn't have value
QWebPage::CopyImageUrl
https://bugs.webkit.org/show_bug.cgi?id=52974

Attachment 80756: patch2
https://bugs.webkit.org/attachment.cgi?id=80756&action=review

------- Additional Comments from Benjamin Poulain <benjamin.poulain at nokia.com>
You should not have to create the action yourself like you do in QTestBrowser.
QWebPage::action() should give you the action. You forgot to implement that
part, that is why you need that code in QtTestBrowser.


More information about the webkit-reviews mailing list