[webkit-reviews] review denied: [Bug 53299] Web Inspector: Use DIVs instead of TABLE in TextViewer : [Attachment 80754] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 1 06:47:25 PST 2011


Pavel Feldman <pfeldman at chromium.org> has denied Andrey Adaikin
<aandrey at google.com>'s request for review:
Bug 53299: Web Inspector: Use DIVs instead of TABLE in TextViewer
https://bugs.webkit.org/show_bug.cgi?id=53299

Attachment 80754: Patch
https://bugs.webkit.org/attachment.cgi?id=80754&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80754&action=review

Few minor nits, otherwise looks good.

> Source/WebCore/inspector/front-end/TextViewer.js:41
>      this.element.addEventListener("keydown", this._handleKeyDown.bind(this),
false);

Why is this registered not in the this._mainPanel?

> Source/WebCore/inspector/front-end/TextViewer.js:48
> +    this._mainPanel.syncScrollListener = this._syncScroll.bind(this);

Can we pass these as constructor parameters instead? (they are not
re-assignable, right?)

> Source/WebCore/inspector/front-end/TextViewer.js:166
> +	   if (lineNumber >= this._textModel.linesCount)

Can this actually happen?

> Source/WebCore/inspector/front-end/TextViewer.js:572
> +    this.element.addEventListener("DOMCharacterDataModified",
this._handleDomUpdates.bind(this), false);

should be handleDOMUpdates. Again, do you want to reuse the bound instance?

> Source/WebCore/inspector/front-end/TextViewer.js:898
> +		   this._syncDecorationsForLineListener(lineRow.lineNumber);

This does not look robust. Are you sure you need it?

> Source/WebCore/inspector/front-end/TextViewer.js:930
> +	   this.element.appendChild(document.createElement("br"));

Will this affect drag'n'drop / copy?


More information about the webkit-reviews mailing list