[webkit-reviews] review denied: [Bug 12448] small text which is scaled to be large renders pixelated : [Attachment 80736] Patch v1

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 12448: small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448

Attachment 80736: Patch v1
https://bugs.webkit.org/attachment.cgi?id=80736&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80736&action=review

The patch itself looks good. Please fix the builds as well as the noted issues
and upload at least the pixel/DRT tests + results of the new tests.

> Source/WebCore/rendering/svg/SVGInlineTextBox.cpp:153
> +    // If the absolute font size on screen is below x=0.5, 't render
anything.

s/'t/don't/

> Source/WebCore/svg/SVGFont.cpp:258
> +	       ASSERT(renderObject->parent());

You call renderObject->parent() multiple times (you use it at least 3 times for
debug build) can save the pointer please?

> Source/WebCore/svg/SVGFont.cpp:412
> +	       ASSERT(renderObject->parent());

ditto.

> Source/WebCore/svg/SVGFont.cpp:502
> +	       ASSERT(renderObject->parent());

ditto.

> Source/WebCore/svg/SVGFont.cpp:547
> +			   ASSERT(renderObject);

you asserted this at the beginning already.It might be unnecessary if you store
the pointer in a local variable before entering this condition.