[webkit-reviews] review granted: [Bug 53476] Fix some Visual Studio compiler warnings : [Attachment 80721] v1 patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Darin Fisher (:fishd, Google)
<fishd at chromium.org>'s request for review:
Bug 53476: Fix some Visual Studio compiler warnings
https://bugs.webkit.org/show_bug.cgi?id=53476

Attachment 80721: v1 patch
https://bugs.webkit.org/attachment.cgi?id=80721&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80721&action=review

looks fine.

> Source/WebKit/chromium/src/WebFrameImpl.cpp:689
> +    for (size_t sourceIndex = 0; j < forms->length(); ++sourceIndex) {

I don't understand why renaming i to j here, but OK...

> Source/WebKit/chromium/src/WebViewImpl.cpp:1619
> +	   float zoomFactor =
static_cast<float>(zoomLevelToZoomFactor(m_zoomLevel));

Maybe this should have float in its name some where?