[webkit-reviews] review requested: [Bug 48459] Glyphs in vertical text tests are rotated 90 degrees clockwise on Windows : [Attachment 80731] add more comments and prevent crash in English environment

[bugzilla-daemon at webkit.org]

Chun-Lung Huang <alvincl.huang at gmail.com> has asked  for review:
Bug 48459: Glyphs in vertical text tests are rotated 90 degrees clockwise on
Windows
https://bugs.webkit.org/show_bug.cgi?id=48459

Attachment 80731: add more comments and prevent crash in English environment
https://bugs.webkit.org/attachment.cgi?id=80731&action=review

------- Additional Comments from Chun-Lung Huang <alvincl.huang at gmail.com>
1. Thanks for all comments.  I've added some descriptive comments and tested
new patch in English environment.  It will not crash in English environment and
basics are working.  What should I do next?

2. BTW, after doing 'svn update', I found that the newest WebKit nightly build,
WebKit r77046(Windows), cannot correctly render pages with
{-webkit-writing-mode: vertical-rl;}.  If you scroll left, WebKit shows you
nothing!
http://www.flickr.com/photos/burorly/5406277169/

It was there before my patch and I found that 'WebKit-r76750' works fine but
'WebKit-r76926' begins to behave unexpected.  A bug?


Alvin