[webkit-reviews] review denied: [Bug 32561] Provide a OProfile JIT agent (opagent) for the code generated by the JIT : [Attachment 75792] jitoprofile.diff

[bugzilla-daemon at webkit.org]

Gabor Loki <loki at webkit.org> has denied Xan Lopez <xan.lopez at gmail.com>'s
request for review:
Bug 32561: Provide a OProfile JIT agent (opagent) for the code generated by the
JIT
https://bugs.webkit.org/show_bug.cgi?id=32561

Attachment 75792: jitoprofile.diff
https://bugs.webkit.org/attachment.cgi?id=75792&action=review

------- Additional Comments from Gabor Loki <loki at webkit.org>
First of all thanks for the update, I am deeply obliged to you!
Unfortunately this patch does not build on many platforms. We should work
further on the patch to fix them. So, I am going to set the r? to r- because of
the builds.

In order to fix the Qt build you should add
 * 'tools/JITProfileAgent.cpp \' line to the 'SOURCES +=' section in
Source/JavaScriptCore/JavaScriptCore.pro
 * and '$$PWD/tools \' line to to the 'JAVASCRIPTCORE_INCLUDEPATH =' section in

Source/JavaScriptCore/JavaScriptCore.pri

Xan, could you update the patch again (because of the top Source directory) ?

I feel there is another issue about the codeBlock->lineInfo() function.
Unfortunately I had no time to debug the code, but I have tried the jsc binary
on ARM and the annotation was failed. There was no or not enough valid lineinfo
data in the saved jitdump file. The correlation between source annotation and
profile report was not sufficient. Xan, is the source annotation working for
you?

One more thing. You changed the name of registerJITCodeImpl function to
recordJITCodeImpl, but you forgot to change the dummy one (when
JIT_OPROFILE_AGENT==0) to the similar name.