[webkit-reviews] review granted: [Bug 75402] Use overload methods to implement [Optional] parameters in AudioNode.idl : [Attachment 120826] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Raymond <rgbbones at gmail.com>'s
request for review:
Bug 75402: Use overload methods to implement [Optional] parameters in
AudioNode.idl
https://bugs.webkit.org/show_bug.cgi?id=75402

Attachment 120826: Patch
https://bugs.webkit.org/attachment.cgi?id=120826&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120826&action=review


Looks great!  Thanks.

> Source/WebCore/webaudio/AudioNode.h:122
> +    void connect(AudioNode*, ExceptionCode&);
> +    void connect(AudioNode*, unsigned outputIndex, ExceptionCode&);
> +    void connect(AudioNode*, unsigned outputIndex, unsigned inputIndex,
ExceptionCode&);
> +    void disconnect(ExceptionCode&);
> +    void disconnect(unsigned outputIndex, ExceptionCode&);

You can use [Optional=CallWithDefaultValue] if you don't want to create all
these symbols.