[webkit-reviews] review granted: [Bug 75375] Cache and reuse the HTMLFormElement.elements collection. : [Attachment 120811] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 30 12:03:25 PST 2011
Anders Carlsson <andersca at apple.com> has granted Andreas Kling
<kling at webkit.org>'s request for review:
Bug 75375: Cache and reuse the HTMLFormElement.elements collection.
https://bugs.webkit.org/show_bug.cgi?id=75375
Attachment 120811: Patch
https://bugs.webkit.org/attachment.cgi?id=120811&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=120811&action=review
> Source/WebCore/html/HTMLCollection.cpp:58
> + if (m_baseIsRetained)
> + m_base->ref();
I think you need to deref m_base in the destructor.
More information about the webkit-reviews
mailing list