[webkit-reviews] review denied: [Bug 75384] [GTK] Scrollbars are drawn behind the window resize grip : [Attachment 120791] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 75384: [GTK] Scrollbars are drawn behind the window resize grip
https://bugs.webkit.org/show_bug.cgi?id=75384

Attachment 120791: Patch
https://bugs.webkit.org/attachment.cgi?id=120791&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120791&action=review


This patch should probably also add support for resizing the scrollbars. Right
now the information is just ignored. We also need to consider how to handle the
situation where the resize grip and the scrollbar don't intersect. For
instance, one such situation would be when the WebView doesn't touch the bottom
of the window at all.
\\

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:75
> +static void webkitWebViewBaseNotifyResizerSizeForWindow(WebKitWebViewBase*
webViewBase, GtkWindow* window)

I think you can just eliminate this completely and call
toplevelWindowResizeGripVisibilityChanged(G_OBJECT(toplevel),  0, webView)
below.