[webkit-reviews] review granted: [Bug 74723] REGRESSION (r94492): Text is shifted to the right in some buttons in the Mac App Store : [Attachment 120660] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Robert Hogan <robert at webkit.org>'s request for
review:
Bug 74723: REGRESSION (r94492): Text is shifted to the right in some buttons in
the Mac App Store
https://bugs.webkit.org/show_bug.cgi?id=74723

Attachment 120660: Patch
https://bugs.webkit.org/attachment.cgi?id=120660&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=120660&action=review


This is getting really close so I am going to say r+ but I think you can
improve it a little.

> Source/WebCore/ChangeLog:17
> +	   (WebCore::LineInfo::positionedObjectsInLeadingWhitespace):

On further thought, this is not the best name. It’s both inaccurate (positioned
objects that were not originally inline aren’t counted) and indirect. A better
name would be “runsFromLeadingWhitespace”.

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:1881
> +    lineInfo.resetPositionedObjectsInLeadingWhitespace();

I think it makes more sense for this to be called by
layoutRunsAndFloatsInRange() just after calling setEmpty().