[webkit-reviews] review requested: [Bug 75232] REGRESSION (WebKit2): Printing a subframe containing a PDF prints the on-screen view instead of the entire PDF document : [Attachment 120764] Proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 29 12:22:26 PST 2011


mitz at webkit.org has asked  for review:
Bug 75232: REGRESSION (WebKit2): Printing a subframe containing a PDF prints
the on-screen view instead of the entire PDF document
https://bugs.webkit.org/show_bug.cgi?id=75232

Attachment 120764: Proposed fix
https://bugs.webkit.org/attachment.cgi?id=120764&action=review

------- Additional Comments from mitz at webkit.org
- Still haven’t looked into the Windows build issue
- Omitted the PrintInfo change which wasn’t closely related
- Added rounding when centering
- Added an empty-check in isDisplayingPDFDocument()
- Added an empty-crop-box check


More information about the webkit-reviews mailing list