[webkit-reviews] review granted: [Bug 75361] Use HashMap<OwnPtr> in RenderSVGResourcePattern : [Attachment 120755] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 29 10:08:41 PST 2011


Andreas Kling <kling at webkit.org> has granted Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>'s request for review:
Bug 75361: Use HashMap<OwnPtr> in RenderSVGResourcePattern
https://bugs.webkit.org/show_bug.cgi?id=75361

Attachment 120755: Patch
https://bugs.webkit.org/attachment.cgi?id=120755&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120755&action=review


> Source/WebCore/rendering/svg/RenderSVGResourcePattern.h:70
> -    HashMap<RenderObject*, PatternData*> m_pattern;
> +    HashMap<RenderObject*, OwnPtr<PatternData> > m_pattern;

m_pattern is not a great name for a hash map containing multiple patterns.


More information about the webkit-reviews mailing list