[webkit-reviews] review denied: [Bug 75319] getComputedStyle for border is not implemented. : [Attachment 120729] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Alexis Menard
<alexis.menard at openbossa.org>'s request for review:
Bug 75319: getComputedStyle for border is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75319

Attachment 120729: Patch
https://bugs.webkit.org/attachment.cgi?id=120729&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120729&action=review


>
LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-shorthand-expecte
d.txt:116
> +PASS computedStyle.getPropertyCSSValue('border').cssText is '320px solid
rgb(255, 0, 0), 320px solid rgb(255, 0, 0), 320px solid rgb(255, 0, 0), 320px
solid rgb(255, 0, 0)'

This doesn't parse when assigned to border. I think it's important that the
value returned by getComputedStyle is a valid CSS value.

There are some values where border can't represent the border state (when they
are different for each side).  I think we have 2 options:
1) Never return a value for border (what we do now).
2) Check to see if the four borders are the same and return the computed style
if they are all the same.  Otherwise return nothing.