[webkit-reviews] review granted: [Bug 75359] It should be easier to iterate a Vector backwards : [Attachment 120753] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 75359: It should be easier to iterate a Vector backwards
https://bugs.webkit.org/show_bug.cgi?id=75359

Attachment 120753: Patch
https://bugs.webkit.org/attachment.cgi?id=120753&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=120753&action=review


> Tools/ChangeLog:11
> +	   to work on windows.

Please explain why we set GTEST_HAS_TR1_TUPLE to 0 here.

> Tools/TestWebKitAPI/Tests/Vector.cpp:82
> +// Vector::reveresed() can only be tested if auto and range-for support is
> +// availiable.

Typo, reveresed. Also, this isn't true. You could do something like

for (Vector<int>::const_iterator it = intVector.reversed.begin(), end =
intVector.reversed.end(); it != end; ++it) { }