[webkit-reviews] review denied: [Bug 75319] getComputedStyle for border is not implemented. : [Attachment 120689] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 28 13:59:11 PST 2011


Tony Chang <tony at chromium.org> has denied Alexis Menard
<alexis.menard at openbossa.org>'s request for review:
Bug 75319: getComputedStyle for border is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75319

Attachment 120689: Patch
https://bugs.webkit.org/attachment.cgi?id=120689&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120689&action=review


> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2146
> +	       list->append(getPropertyCSSValue(CSSPropertyBorderTop,
DoNotUpdateLayout));
> +	       list->append(getPropertyCSSValue(CSSPropertyBorderRight,
DoNotUpdateLayout));
> +	       list->append(getPropertyCSSValue(CSSPropertyBorderBottom,
DoNotUpdateLayout));
> +	       list->append(getPropertyCSSValue(CSSPropertyBorderLeft,
DoNotUpdateLayout));

Can you use getCSSPropertyValuesForShorthandProperties here?


More information about the webkit-reviews mailing list