[webkit-reviews] review granted: [Bug 75274] Enable the [Supplemental] IDL on Qt : [Attachment 120670] WIP patch to see if build passes

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 75274: Enable the [Supplemental] IDL on Qt
https://bugs.webkit.org/show_bug.cgi?id=75274

Attachment 120670: WIP patch to see if build passes
https://bugs.webkit.org/attachment.cgi?id=120670&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120670&action=review


>> Source/WebCore/DerivedSources.pri:662
>> +resolveSupplemental.commands = echo $(addprefix
$${ROOT_WEBKIT_DIR}/Source/WebCore/, $$IDL_BINDINGS) | sed \'s/\\s/\\n/g\' >
$$IDL_FILES_TMP && \
> 
> I am a bit afraid if the echo arguments exceed the OS limit on Qt/Mac and
Qt/Win, although it passes Qt/Linux build. In AppleWebKit and Gtk, we have
explicitly avoided this issue by $(foreach...) trick (See the patch of bug
74972), but it appears that qmake does not have $(foreach...) or something like
that.
> 
> That being said, I found much longer arguments when Qt links libwebcore.a at
the final stage. So the echo arguments might not become a problem.

You'll probably want to check with some Qt folks after this lands to make sure
its ok.