[webkit-reviews] review granted: [Bug 74743] getComputedStyle for border-bottom, border-top, border-left, border-right is not implemented. : [Attachment 120654] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 28 09:43:53 PST 2011
Tony Chang <tony at chromium.org> has granted Alexis Menard
<alexis.menard at openbossa.org>'s request for review:
Bug 74743: getComputedStyle for border-bottom, border-top, border-left,
border-right is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=74743
Attachment 120654: Patch
https://bugs.webkit.org/attachment.cgi?id=120654&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120654&action=review
> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2144
> + const int properties[3] = { CSSPropertyBorderBottomWidth,
CSSPropertyBorderBottomStyle,
> + CSSPropertyBorderBottomColor};
Nit: Space before }
> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2151
> + const int properties[3] = { CSSPropertyBorderLeftWidth,
CSSPropertyBorderLeftStyle,
> + CSSPropertyBorderLeftColor};
Nit: Space before }
> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2159
> + const int properties[3] = { CSSPropertyBorderRightWidth,
CSSPropertyBorderRightStyle,
> + CSSPropertyBorderRightColor};
Nit: Space before }
> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2166
> + const int properties[3] = { CSSPropertyBorderTopWidth,
CSSPropertyBorderTopStyle,
> + CSSPropertyBorderTopColor};
Nit: Space before }
More information about the webkit-reviews
mailing list