[webkit-reviews] review canceled: [Bug 71568] [GTK] Add a way to change web view settings in MiniBrowser : [Attachment 114501] Updated patch to not use G_VALUE_INIT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 28 06:38:04 PST 2011


Carlos Garcia Campos <cgarcia at igalia.com> has canceled Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 71568: [GTK] Add a way to change web view settings in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=71568

Attachment 114501: Updated patch to not use G_VALUE_INIT
https://bugs.webkit.org/attachment.cgi?id=114501&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
Several fixes in this new patch:

 - Support all setting types (boolean, string and uint)
 - Fix compile warning with the GValue stack initialization.
 - Use GtkToolItem instead of GtkMenuToolItem for the preferences toolbar
button.
 - Use the property nick instead of the property name in the dialog.
 - Show the property blurb as a tooltip.


More information about the webkit-reviews mailing list