[webkit-reviews] review denied: [Bug 75228] Web Inspector: Introduce a Profiler launcher view similar to that in the Audits panel : [Attachment 120656] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 75228: Web Inspector: Introduce a Profiler launcher view similar to that in
the Audits panel
https://bugs.webkit.org/show_bug.cgi?id=75228

Attachment 120656: Patch
https://bugs.webkit.org/attachment.cgi?id=120656&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120656&action=review


> Source/WebCore/inspector/front-end/ProfileLauncherView.js:87
> +	      
this.dispatchEventToListeners(WebInspector.ProfileLauncherView.EventTypes.Profi
leTypeSelected, { profileType: profileType });

Why not to pass profileType as an event data instead?

> Source/WebCore/inspector/front-end/ProfilesPanel.js:280
> +	       // Retain the profile type registration order in the tree, too.

I don't think you need this logic.

> Source/WebCore/inspector/front-end/ProfilesPanel.js:1032
> +    onattach: function()

Why do you need this override?

> Source/WebCore/inspector/front-end/ProfilesPanel.js:1049
> +	   this.refreshTitles();

Where is this defined? Why doesn't it work be default?