[webkit-reviews] review denied: [Bug 75217] [Forms] Use enum instead of bool for HTMLInputElement::setValue : [Attachment 120519] Patch 1

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 75217: [Forms] Use enum instead of bool for HTMLInputElement::setValue
https://bugs.webkit.org/show_bug.cgi?id=75217

Attachment 120519: Patch 1
https://bugs.webkit.org/attachment.cgi?id=120519&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120519&action=review


> Source/WebCore/html/HTMLInputElement.cpp:1098
> +    // FIXME: Why do we do this when !eventBehavior?

"!eventBehavior" looks incorrect.

> Source/WebCore/html/HTMLTextFormControlElement.h:37
> +enum TextFieldEventBehavior { DispatchNoEvent, DispatchChangeEvent,
DispatchInputEvent, DispatchInputAndChangeEvent };

Please add an explanation why we have four different values to ChangeLog though
we replace a bool value.