[webkit-reviews] review denied: [Bug 75168] [TexMap][QT] The fragment shader in OpenGL ES2 requires the default precision qualifier. : [Attachment 120453] patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 75168: [TexMap][QT] The fragment shader in OpenGL ES2 requires the default
precision qualifier.
https://bugs.webkit.org/show_bug.cgi?id=75168

Attachment 120453: patch
https://bugs.webkit.org/attachment.cgi?id=120453&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=120453&action=review


> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:317
> +#define OES2_FRAGMENT_SHADER_DEFAULT_PRECISION
>  #else
>  #define OES2_PRECISION_DEFINITIONS
> +#define OES2_FRAGMENT_SHADER_DEFAULT_PRECISION \
> +    "precision mediump float; \n"

Can't you just add it to the OES2_PRECISION_DEFINITIONS define instead of
creating a new one?