[webkit-reviews] review granted: [Bug 74954] Web Inspector: CodeGeneratorInspector.py: generate enum types. : [Attachment 120601] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 27 11:28:35 PST 2011


Yury Semikhatsky <yurys at chromium.org> has granted Peter Rybin
<peter.rybin at gmail.com>'s request for review:
Bug 74954: Web Inspector: CodeGeneratorInspector.py: generate enum types.
https://bugs.webkit.org/show_bug.cgi?id=74954

Attachment 120601: Patch
https://bugs.webkit.org/attachment.cgi?id=120601&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120601&action=review


> Source/WebCore/inspector/CodeGeneratorInspector.py:54
> +    "": "Empty",

Please change this to some non-empty constant ("regular" should be find for
CSSRule.origin as we discussed offline) or  file a bug about this.


More information about the webkit-reviews mailing list