[webkit-reviews] review granted: [Bug 75245] Web Inspector: Scripts panel tabbed editor does not reopen closed tabs. : [Attachment 120576] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 27 08:06:53 PST 2011
Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 75245: Web Inspector: Scripts panel tabbed editor does not reopen closed
tabs.
https://bugs.webkit.org/show_bug.cgi?id=75245
Attachment 120576: Patch
https://bugs.webkit.org/attachment.cgi?id=120576&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120576&action=review
>> Source/WebCore/inspector/front-end/TabbedPane.js:126
>> + var event = {tabId: id, view: tab.view, isUserGesture:
userGesture};
>
> we typically separate object contents by spaces inside braces: { tabId: ...
userGesture } - I remember getting a similar comment from Joe Pecoraro.
var eventData = { ... } (it'll be event.data, not event).
More information about the webkit-reviews
mailing list