[webkit-reviews] review granted: [Bug 75229] Web Inspector: Extract FileEditor from ScriptsPanel. : [Attachment 120557] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 75229: Web Inspector: Extract FileEditor from ScriptsPanel.
https://bugs.webkit.org/show_bug.cgi?id=75229

Attachment 120557: Patch
https://bugs.webkit.org/attachment.cgi?id=120557&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120557&action=review


Please rename new interface and a class prior to landing.

> Source/WebCore/inspector/front-end/ScriptsPanel.js:1073
> +WebInspector.ScriptsPanel.FileEditor = function() { }

FileEditor is not a great name for this. We have TextViewer (that was renamed
from TextEditor when we stripped editing capabilities that should be renamed
back). This looks like a WebInspector.EditorContainer to me.

> Source/WebCore/inspector/front-end/UISourceCode.js:145
> +	   if (!this._fileName)

What if fileName is "" ?