[webkit-reviews] review granted: [Bug 75226] Web Inspector: [Scripts] Implement iterative match highlighting in the "Go to Function" dialog item list : [Attachment 120553] [PATCH] Comments addressed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 26 06:35:24 PST 2011


Pavel Feldman <pfeldman at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 75226: Web Inspector: [Scripts] Implement iterative match highlighting in
the "Go to Function" dialog item list
https://bugs.webkit.org/show_bug.cgi?id=75226

Attachment 120553: [PATCH] Comments addressed
https://bugs.webkit.org/attachment.cgi?id=120553&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120553&action=review


> Source/WebCore/inspector/front-end/JavaScriptOutlineDialog.js:232
> +	       this._startMatchHighlighting();

clearHighlight

> Source/WebCore/inspector/front-end/JavaScriptOutlineDialog.js:274
> +    _startMatchHighlighting: function(query)

inline

> Source/WebCore/inspector/front-end/JavaScriptOutlineDialog.js:465
> +    start: function(query)

highlightViewportItems


More information about the webkit-reviews mailing list