[webkit-reviews] review denied: [Bug 75226] Web Inspector: [Scripts] Implement iterative match highlighting in the "Go to Function" dialog item list : [Attachment 120550] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 75226: Web Inspector: [Scripts] Implement iterative match highlighting in
the "Go to Function" dialog item list
https://bugs.webkit.org/show_bug.cgi?id=75226

Attachment 120550: Patch
https://bugs.webkit.org/attachment.cgi?id=120550&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120550&action=review


> Source/WebCore/inspector/front-end/JavaScriptOutlineDialog.js:455
> +	   this._regExp = query ? this._dialog._createSearchRegExp(query, true)
: null;

this._regex

> Source/WebCore/inspector/front-end/JavaScriptOutlineDialog.js:475
> +	   if (this._highlightTimer)

So is this this._timer or this._highlightTimer?

> Source/WebCore/inspector/front-end/JavaScriptOutlineDialog.js:483
> +	   const chunkSize = 50;

It seems like computing visible range and highlighting it synchronously might
require less code.

> Source/WebCore/inspector/front-end/JavaScriptOutlineDialog.js:499
> +	   var text = element._text;

Could you use highlightRangesWithStyleClass instead?