[webkit-reviews] review denied: [Bug 75092] Web Inspector: Implement "Go to Function" dialog for JavaScript : [Attachment 120470] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 26 01:19:49 PST 2011


Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 75092: Web Inspector: Implement "Go to Function" dialog for JavaScript
https://bugs.webkit.org/show_bug.cgi?id=75092

Attachment 120470: Patch
https://bugs.webkit.org/attachment.cgi?id=120470&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120470&action=review


> Source/WebCore/inspector/front-end/JavaScriptOutlineDialog.js:407
> +WebInspector.JavaScriptOutlineDialog.MatchHighlighter = function(dialog)

Lets land highlighter as a separate change.

> Source/WebCore/inspector/front-end/inspector.html:36
> +    <link rel="stylesheet" type="text/css"
href="javaScriptOutlineDialog.css">

This css should be lazily loaded.


More information about the webkit-reviews mailing list