[webkit-reviews] review denied: [Bug 75222] Use OwnPtr for FillLayer::m_next : [Attachment 120525] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Darin Adler <darin at apple.com>'s request for review:
Bug 75222: Use OwnPtr for FillLayer::m_next
https://bugs.webkit.org/show_bug.cgi?id=75222

Attachment 120525: Patch
https://bugs.webkit.org/attachment.cgi?id=120525&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=120525&action=review


r- because of a logic mistake I spotted in imagesAreLoaded().

> Source/WebCore/rendering/style/FillLayer.cpp:80
>  FillLayer::~FillLayer()
>  {
> -    delete m_next;
>  }

Wouldn’t the compiler generate this destructor if you omitted it (and didn’t
declare it)?

> Source/WebCore/rendering/style/FillLayer.cpp:255
> -	       return false;
> +    for (const FillLayer* layer = this; layer; layer = layer->m_next.get())
{
> +	   if (layer->m_image && !layer->m_image->isLoaded())
> +	       return true;

Should return false here.