[webkit-reviews] review granted: [Bug 75190] Allow XMLHttpRequest responseType to be set prior to a call to open() : [Attachment 120507] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Jarred Nicholls
<jarred at webkit.org>'s request for review:
Bug 75190: Allow XMLHttpRequest responseType to be set prior to a call to
open()
https://bugs.webkit.org/show_bug.cgi?id=75190

Attachment 120507: Patch
https://bugs.webkit.org/attachment.cgi?id=120507&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120507&action=review


Looks great.

> Source/WebCore/ChangeLog:3
> +	   Allow XMLHttpRequest responseType to be set prior to a call to
open()

The bug title is now slightly misleading, as we ended up allowing more than
that.

> Source/WebCore/ChangeLog:10
> +	   See http://dvcs.w3.org/hg/xhr/raw-file/tip/Overview.html

Generally, giving URLs to common specs is not very helpful. It's easy to find
these, URLs change with time, and length of explanatory text increases
cognitive load.

It's not immediately clear how this fairly long description relates to the
change. I'd say something like "The most practically interesting aspect of this
change is that responseType attribute can be set before a call to open().
Therefore, <...>".