[webkit-reviews] review denied: [Bug 74723] REGRESSION (r94492): Text is shifted to the right in some buttons in the Mac App Store : [Attachment 120467] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Robert Hogan <robert at webkit.org>'s request for
review:
Bug 74723: REGRESSION (r94492): Text is shifted to the right in some buttons in
the Mac App Store
https://bugs.webkit.org/show_bug.cgi?id=74723

Attachment 120467: Patch
https://bugs.webkit.org/attachment.cgi?id=120467&action=review

------- Additional Comments from mitz at webkit.org
Using RenderBlock::m_positioned for this seems unnecessarily complex and
dangerous. Moreover, this patch doesn’t handle bidirectional reordering
correctly. I think this bug can be fixed simply and correctly by just patching
skipLeadingWhitespace() to create and add a BidiRun for each formerly-inline
positioned object it encounters.