[webkit-reviews] review granted: [Bug 75191] Add unittests for the C++ parser of prepare-ChangeLog : [Attachment 120495] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 75191: Add unittests for the C++ parser of prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=75191

Attachment 120495: Patch
https://bugs.webkit.org/attachment.cgi?id=120495&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120495&action=review


>>
Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp
:73
>> +char *str = "abcde"
> 
> Declaration has space between type name and * in char *str 
[whitespace/declaration] [3]

Is wrong style for pointer intentional? But we aren't really testing string
literal parsing, right? So it seems like it's better to follow WebKit style
here.

>>
Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp
:160
>> +{
> 
> This { should be at the end of the previous line  [whitespace/braces] [4]

One of these classes should follow WebKit style and put { on the same line as
Class1.