[webkit-reviews] review denied: [Bug 75190] Allow XMLHttpRequest responseType to be set prior to a call to open() : [Attachment 120493] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 24 10:41:40 PST 2011


Alexey Proskuryakov <ap at webkit.org> has denied Jarred Nicholls
<jarred at webkit.org>'s request for review:
Bug 75190: Allow XMLHttpRequest responseType to be set prior to a call to
open()
https://bugs.webkit.org/show_bug.cgi?id=75190

Attachment 120493: Patch
https://bugs.webkit.org/attachment.cgi?id=120493&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120493&action=review


> Source/WebCore/xml/XMLHttpRequest.cpp:295
> -    if (m_state != OPENED || m_loader) {
> +    if (m_state >= LOADING || m_loader) {

Actually, I think that the m_loader check here is now incorrect.


More information about the webkit-reviews mailing list