[webkit-reviews] review granted: [Bug 75173] Web Inspector: Extract FileSelector from ScriptsPanel. : [Attachment 120468] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 75173: Web Inspector: Extract FileSelector from ScriptsPanel.
https://bugs.webkit.org/show_bug.cgi?id=75173

Attachment 120468: Patch
https://bugs.webkit.org/attachment.cgi?id=120468&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120468&action=review


> Source/WebCore/inspector/front-end/ScriptsPanel.js:174
> +    this._sourceFramesByUISourceCodes = new Map();

this._sourceFramesByUISourceCode (not plural)

> Source/WebCore/inspector/front-end/ScriptsPanel.js:264
> +	   uiSourceCodes = this._sourceFramesByUISourceCodes;

var uiSourceCode (please run compiler)

> Source/WebCore/inspector/front-end/ScriptsPanel.js:487
> +	   this._sourceFramesByUISourceCodes.put(uiSourceCode, sourceFrame)

missing ;

> Source/WebCore/inspector/front-end/ScriptsPanel.js:-654
> -	   if (this._navigator)

no delegation to the file selector here. why?

> Source/WebCore/inspector/front-end/ScriptsPanel.js:-733
> -	       // FIXME: We should always add anonymous scripts to navigator
(in a separate folder tree element)

This fixme should probably stay.

> Source/WebCore/inspector/front-end/ScriptsPanel.js:974
> +    get defaultFocusedElement() { },

long term it should be get view()?

> Source/WebCore/inspector/front-end/ScriptsPanel.js:979
> +    show: function(element) { },

Open comment: Imagine that we end up leaving both: simple file selector and
navigator panel. You will then need to delegate editor layout to that
component. As a result, you no longer need to expose show /
defaultFocusedElement at all.

> Source/WebCore/inspector/front-end/ScriptsPanel.js:995
> +    setScriptSourceIsBeingEdited: function(uiSourceCode, inEditMode) { },

You rather need a "dirty" marker, not inEditMode.

> Source/WebCore/inspector/front-end/ScriptsPanel.js:1001
> +    replaceUISourceCodes: function(oldUISourceCodeList, uiSourceCodeList) {
},

trailing coma

> Source/WebCore/inspector/front-end/ScriptsPanel.js:1022
> +WebInspector.ScriptsPanel.SimpleFileSelector.prototype = {

ComboBoxFileSelector or DropBoxFileSelector?