[webkit-reviews] review canceled: [Bug 53644] [GTK] editing/deleting/5408255.html results are incorrect : [Attachment 118807] Patch

[bugzilla-daemon at webkit.org]

Zan Dobersek <zandobersek at gmail.com> has canceled Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 53644: [GTK] editing/deleting/5408255.html results are incorrect
https://bugs.webkit.org/show_bug.cgi?id=53644

Attachment 118807: Patch
https://bugs.webkit.org/attachment.cgi?id=118807&action=review

------- Additional Comments from Zan Dobersek <zandobersek at gmail.com>
This is just a WIP patch on which I'd like some comments.

I've introduced a new macro, TOP_LEVEL_DIR, in Tools/GNUmakefile.am. It is
later used in DumpRenderTree.cpp as a return value when calling
getTopLevelPath. Also in that function, if environment variable
WEBKIT_TOP_LEVEL is not set, it is set to the value of the TOP_LEVEL_DIR macro.


This nullifies the need of setting the WEBKIT_TOP_LEVEL variable in testing
environment, so this is not done anymore in the GtkPort in webkitpy.

In ImageGtk.cpp, resource is loaded from the checkout tree if WEBKIT_TOP_LEVEL
is set (now only if DumpRenderTree is run) or from DATA_DIR otherwise. Smart
pointer is not used at this moment as I believe there's no need for it based on
the path acquiring that is used in this patch.

This patch leaves the resource loading on Windows platform pretty broken. I'm
not able to test the changes for this platform, so the best I can do is a blind
guess at how things should be handled.

I'd like to hear some comments on this patch and especially the Windows issue,
and because this patch is more of a WIP/RFC, I'm not setting any flags on this
patch.